Skip to content

Add bactmap_update_global_use.config file#995

Open
iamamofa wants to merge 1 commit intomasterfrom
iamamofa-patch-2
Open

Add bactmap_update_global_use.config file#995
iamamofa wants to merge 1 commit intomasterfrom
iamamofa-patch-2

Conversation

@iamamofa
Copy link


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

@pontus
Copy link
Collaborator

pontus commented Dec 17, 2025

Similar to #994, I don't think I understand the intention here.

The "new" file has several things that do not seem suitable for a pipeline configuration (that should apply in all cases where the pipeline is used).

There's also change of filename. While I haven't checked the bactmap pipeline, it seems this would rather make the configuration not being found.

Should this rather be targeting some /configs/conf/pipeline/bactmap/SOMEPROFILE.config?

@jfy133
Copy link
Member

jfy133 commented Jan 22, 2026

I agree with @pontus here, could you explain what you are trying to do here @iamamofa ?

@jfy133
Copy link
Member

jfy133 commented Jan 22, 2026

@nf-core-bot fix linting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants